Make metadata RE reluctant (stop on first = not last) #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescasbon
pushed a commit
that referenced
this pull request
Jun 18, 2012
Make metadata RE reluctant (stop on first = not last)
gotgenes
pushed a commit
to gotgenes/PyVCF
that referenced
this pull request
May 13, 2014
Make metadata RE reluctant (stop on first = not last)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @dzerbino for many fixes. The metadata hash added here: d928de1#L2R170
fixed mis-parsing contigs with internal =, but a UnifiedGenotyper metadata line isn't wrapped in angle brackets and is thus still parsed improperly.
This is a very simple tweak to the RE:
(.+)=(.+) will put everything up to the very last = in the first group because + is greedy by default.
(.+?)=(.+) makes the + reluctant, so only the first group of characters that are not =, aka the key, will be in the first group.